Draft
Conversation
Owner
|
Hey Ammar! Wow, this is absolutely incredible! Thank you so much for your work. Since this is quite a big PR, do you maybe have me on Discord? We could go over some things in DM more quickly - but on the surface everything looks really great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I know you haven't been working on this actively but I thought of takings some time to up a few things. Here's the list:
Schedulersimilar toreact-native-vision-cameraso now it creates it's ownScheduler.assetsfolder & it will be loaded into the worker thread. For example loading ahtml parseror any other such library for doing expensive work on the worker & returning the result.evalsupport.installmethod.